Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4267 and add related unittest #24

Closed
wants to merge 1 commit into from
Closed

Fix #4267 and add related unittest #24

wants to merge 1 commit into from

Conversation

onewa2403
Copy link

For the UnitTest, if you remove the fix you'll see that the deck.GetCards().Values.Sum() return 29 and not 30.

@onewa2403 onewa2403 mentioned this pull request Dec 15, 2021
Closed
@onewa2403 onewa2403 changed the title Fix issue 4267 and add related unittest Fix #4267 and add related unittest Dec 15, 2021
@azeier azeier force-pushed the master branch 2 times, most recently from 74e6fd1 to 52270f6 Compare June 15, 2022 20:20
@beheh beheh mentioned this pull request Jul 4, 2022
Merged
@beheh
Copy link
Contributor

beheh commented Jul 4, 2022

Resolved in #25.

@beheh beheh closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onewa2403 @beheh