Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEG-58 - Change pagination request method to POST #1969

Merged
merged 12 commits into from
Aug 15, 2024
Merged

Conversation

TehAwol
Copy link
Contributor

@TehAwol TehAwol commented Aug 2, 2024

No description provided.

@SandraMonnier
Copy link
Member

SandraMonnier commented Aug 6, 2024

Some characters in the search field lead to an "Error: Failure" notification and an endless loading animation. Such as

"
!
#
%
³
♥

I found all these characters either in abstractaccount.firstname, abstractaccount.lastname, game.name or gamemodel.name.

It works fine for all these special characters
+ * ; , : . / [ ] ( ) @ - _ &

@SandraMonnier
Copy link
Member

Y a encore un truc que je ne comprends pas. Dans la regex (^[\p{L} .'-_()&[0-9]]*$), on a un -. Il est compris comme le symbole - ou c'est pour dire de ' à _ ?

@TehAwol
Copy link
Contributor Author

TehAwol commented Aug 7, 2024

It's the symbol "-" that is covered. Certain special characters are going to break the page regardless, the question also extends to whether users/games/gameModels should be allowed those special characters as names.

@fsantaniello-heigvd fsantaniello-heigvd merged commit df42c83 into dev Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants