Skip to content

[REC] Fury Warrior - Multi Target Rotation Issues #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
Mosborne90 opened this issue Sep 7, 2024 · 4 comments
Closed
5 tasks done

[REC] Fury Warrior - Multi Target Rotation Issues #3682

Mosborne90 opened this issue Sep 7, 2024 · 4 comments
Assignees
Labels
📈 recommendations Ticket is a proposed change to action priorities. retail

Comments

@Mosborne90
Copy link

Mosborne90 commented Sep 7, 2024

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

I discovered two potential issues:

  1. In a multi target scenario with Titan's torment talented, the fury warrior rotation is recommending to use rampage after recklessness+avatar burst. I believe this is incorrect since titan's torment grants the enrage buff. The rotation should move straight into bladestorm. The snapshot showing this behavior is linked below.

  2. A separate issue is the multi target rotation is choosing to refresh the whirlwind buff, even with stacks of the buff remaining over the use of crushing blow when available. Additional testing showed that whirlwind was sometimes recommended over other spells besides crushing blow, even if the player had whirlwind stacks remaining. that snapshot can be found here: https://pastebin.com/LL4B3Dwi

How to Reproduce

Charge into multi target dummies - pop reck/avatar burst, rampage will appear next instead of bladestorm which should then be followed by odyn's fury.

Whirlwind issue - unsure how to reproduce.

Snapshot (Link)

https://pastebin.com/A3GdspY1

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/d8ASqRF7npS69SaqrCgMnL

Additional Information

No response

Contact Information

No response

@Mosborne90 Mosborne90 added 📈 recommendations Ticket is a proposed change to action priorities. 🧑‍⚕️ triage Issue needs initial triage to determine if action needs to be taken. labels Sep 7, 2024
@syrifgit
Copy link
Collaborator

syrifgit commented Sep 7, 2024

In a multi target scenario with Titan's torment talented, the fury warrior rotation is recommending to use rampage after recklessness+avatar burst. I believe this is incorrect since titan's torment grants the enrage buff. The rotation should move straight into bladestorm. The snapshot showing this behavior is linked below.

Yet the sim you linked does exactly this, so it is correct.

image

A separate issue is the multi target rotation is choosing to refresh the whirlwind buff, even with stacks of the buff remaining over the use of crushing blow when available. Additional testing showed that whirlwind was sometimes recommended over other spells besides crushing blow, even if the player had whirlwind stacks remaining. that snapshot can be found here: https://pastebin.com/LL4B3Dwi

I believe I know what is causing this. In the SIMC github, the buff of whirlwind attacks is called meat_cleaver, but in hekili it's called improved_whirlwind still. So when it checks for meat_cleaver, it thinks you have 0. Will get this fixed (eventually).

@syrifgit syrifgit added accepted retail and removed 🧑‍⚕️ triage Issue needs initial triage to determine if action needs to be taken. labels Sep 7, 2024
@Mosborne90
Copy link
Author

@syrifgit Thanks for checking that. I'll be sure to look at the sim next time before a priority recommendation. Glad to know the whirlwind issue is a valid problem though.

@syrifgit
Copy link
Collaborator

syrifgit commented Sep 8, 2024

@syrifgit Thanks for checking that. I'll be sure to look at the sim next time before a priority recommendation. Glad to know the whirlwind issue is a valid problem though.

Interestingly, I couldn't replicate the issue with whirlwind. Can you do a fresh install and APL reset and try to reproduce it again?

image

@Mosborne90
Copy link
Author

Mosborne90 commented Sep 9, 2024

@syrifgit I tested it again after a fresh install and profile reset. I'm able to replicate the bug this way.

  1. have whirlwind stacks before bladestorm
  2. the bug will not occur if you have odyn's fury ready to use. Bladestorm will be followed by odyn's fury which skips the recommendation for whirlwind.
  3. after bladestorm ends, whirlwind is recommended even if you have whirlwind buff stacks remaining.

https://pastebin.com/vBb2Vy1V

vid: https://streamable.com/ths3b8

image

@Hekili Hekili closed this as completed in 32d58df Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 recommendations Ticket is a proposed change to action priorities. retail
Projects
None yet
Development

No branches or pull requests

3 participants