Feature Request: Display more stream information in PlexPy #577
Comments
|
I'll have a hack at this. Fair warning: my coding is pretty poor, I'm an infrastructure engineer :) |
|
How's this look: |
|
That looks perfect, exactly what I was looking for! |
|
Sweet. Just cleaning up a couple of bits and I'll send a pull request to
Hellowlol
…On 1 April 2018 at 13:07, Kazz3r24 ***@***.***> wrote:
That looks perfect, exactly what I was looking for!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#577 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCDZVNCssoTp6cnLFggp_WmMjnHx7SHks5tkChGgaJpZM4SaIX8>
.
|
|
Just realised I didn't include the subtitles line. I've already submitted the pull request. I'm reasonably confident there'll be at least one bug so assuming that I'll be doing an edit on this soon, I'll collapse the top two lines together and add subtitle info then. |
|
Just submitted a PR with a few bugfixes. @Kazz3r24 can you close this issue if you're happy with it? |
|
|
|
It looks pretty much perfect! Exactly what I was looking for. My only issue I'm having, and I'm not sure if it's on my end or where.
The progress bar for media seems to be getting cut off due to large images. So I don't know if it's something I can tweak, or where those settings are. I did already try clearing my browser cache to see if that would fix it, still nothing so far. I also just restarted the service, issue remains. |
|
Once I get that fixed, I'll be 1000% satisfied and will certainly close the issue. Thanks again for all of your hard work! I'll need to brush up on my various coding languages so I can help out! |
|
Wow, that's not looking right. What resolution is your monitor at? I noticed when editing the code that some of the sizing is in "%" and some of it is in pixels. I'm guessing you have a screen size that is quite different to any of mine (I think mine are all 1920x1080) and some of the % width stuff is causing the image to stretch taller to compensate for the increased width. I'll try replicate it but if you could let me know about your screen resolution & whether changing the browser window size helps, that would be great. |
|
PS does it look OK with just one stream playing? |
|
I will have to try it out and see how things look with one stream. My monitor and resolution are 1920x1080 as well. Thanks for looking into this! |
|
@Kazz3r24 fyi I've been able to reproduce your situation. Seems it's totally different in Edge, IE, Chrome and Firefox. Different browser window sizes definitely contribute to it. ...fml.. |
|
LOL I'm sorry this has turned into a bit of a nightmare. I was able to get everything looking normal by shrinking my browser window down. Even with one stream going at full screen the issue remains. If there's anything I can do to help I am more than willing and capable. Thanks for your efforts again! |
|
OK fixed it. Stupid MS Edge is stupid, and I had to rewrite the whole thing to cater for one browser dong tables differently. :) |
|
LOL I could have told your Edge is stupid :P, that's silly... should be standards for that. Either way, I'm going to close this ticket. I believe you've more than exceeded what I asked for and I'll know for sure once the pull request goes through and I update. |
|
@Kazz3r24 just fyi the fixes have been merged in, so check for updates. |
|
Perfect! Sure thing, I'll update as soon as I get a chance and get back to you. Thanks again! |
|
Looks absolutely perfect now! Thank you guys so much for your efforts! |
Reporting Issues:
To ensure that a I has enough information to work with please include all of the following information.
Use proper markdown syntax to structure your post (i.e. code/log in code blocks).
Make sure you provide the following information below:
[2f3e2f0] Version
[master2] Branch
[823791748e5073c1fc19ad42cab55c1f] Commit hash
[Linux-4.13.0-32-generic-x86_64-with-Ubuntu-16.04-xenial] Operating system
[2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]] Python version
[This is just a feature request, no issue. Is it at all possible to add more stream information? I'll post a screen shot link below for context] What you did?
[Everything's working great] What happened?
[Nothing short of what I got, I apologize if I didn't post this feature request properly] What you expected?
[configure PlexPy module] How can we reproduce your issue?
[Not applicable] What are your (relevant) settings?
[] Include a link to your FULL (not just a few lines!) log file that has the error. Please use Gist or Pastebin.
Close your issue when it's solved! If you found the solution yourself please comment so that others benefit from it.
Link to log: https://imgur.com/Z9Ca9v1
The text was updated successfully, but these errors were encountered: