Added auto-refresh setting to dashboard #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
|
Thanks
…On 31 March 2018 at 20:09, Hellowlol ***@***.***> wrote:
Merged #584 <#584>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#584 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABCDZS0iWp1HB2PomC-eIBzJp83P2yTuks5tjyvHgaJpZM4TCSPL>
.
|
jeremysherriff
added a commit
to jeremysherriff/HTPC-Manager
that referenced
this pull request
Mar 31, 2018
Merge pull request Hellowlol#584 from jeremysherriff/master2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works, seems to be robust.
Contains some hacky type-cast stuff to make sure that bogus data (ie text instead of digits) in the refresh interval setting field does not break the dash itself.
I am not convinced that the database value should be fetched and assigned in dash.html (as opposed to dash.js) but every time I try to do it differently it breaks the dashboard page.