Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruusukivi map slider #139

Merged
merged 8 commits into from
Jun 18, 2023
Merged

Ruusukivi map slider #139

merged 8 commits into from
Jun 18, 2023

Conversation

ruusukivi
Copy link
Contributor

@ruusukivi ruusukivi commented Jun 18, 2023

Closes #71

  • Fixed the timeline to be more responsive - should now work both in mobile and desktop even when the user changes the font size between 80% - 125%
  • Refactored code: MUI-theme in assets/theme.js, separate component for Accessibility dropdown
  • Added basic Jest tests for Header and Accessibility components

I could not find where to set the "Current" label in timeslider so that the backend won´t break -> made a bit quick-and-dirty fix in the component

Copy link
Contributor

@JoJoensuu JoJoensuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Tested different window widths and zoom levels. Past 125% window zoom text below the slides goes partially below the map. Might want to address in later PRs.

@JoJoensuu JoJoensuu merged commit 7610cbe into main Jun 18, 2023
@JoJoensuu JoJoensuu deleted the ruusukivi-map-slider branch June 18, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-Slider
3 participants