- Add missing translations to account/users & signin routes #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix signin.signin in English & Dutch
|
bjarneo
added a commit
that referenced
this pull request
Jun 8, 2024
* - Add missing translations to account/users & signin routes - Fix signin.signin in English & Dutch * chore: make things work as expected --------- Co-authored-by: ltguillaume <ltguillaume@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you, @ltguillaume
This PR includes commits from this: #299
Copilot
This pull request primarily focuses on internationalization (i18n) improvements in the
client/routes/account/users.jsxandclient/routes/signin/index.jsxfiles, and the corresponding translations inpublic/locales/en/translation.jsonandpublic/locales/nl/translation.json. The changes involve replacing hard-coded strings with calls to the translation functiont(), which will allow for easier localization of the application in different languages.Internationalization improvements:
client/routes/account/users.jsx: Replaced hard-coded strings in theUsersfunction with calls to the translation functiont(). This includes strings in theopenDeleteModal, error message, input labels and placeholders, and table headers. [1] [2] [3] [4]client/routes/signin/index.jsx: Replaced the hard-coded error message in theSignInfunction with a call to the translation functiont().Translation changes:
public/locales/en/translation.json: Added translations for the strings used inclient/routes/account/users.jsxandclient/routes/signin/index.jsx, and made minor corrections to existing translations. [1] [2] [3] [4]public/locales/nl/translation.json: Made similar changes as in the English translations, and also improved some existing Dutch translations. [1] [2] [3] [4] [5]