-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs, cleanup, examples, and simplified config #9
Conversation
unified configuration adding ability to pass html to defaultTemplate now including babel proper by default add warning/prep for peerDependency deprecation
assets.defaultTemplate = function (opts) { | ||
var templateData = assign({ | ||
charset: 'utf-8', | ||
metaViewPort: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this option be metaViewport
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix
Seems pretty good to me visually. The one line note I left is a small thing, and probably doesnt matter if thats not a public option since I didn't see it documented anywhere else. But if the user is allowed to set it, I think it should be changed. Also @HenrikJoreteg, I assume this is |
"surge": "*" | ||
**using an `html` function to generate specific files** | ||
|
||
This is where it gets interesting. Imagine pre-rendering all known structural content for a Native Web App to static files. Users get pixels on the screen immediately, your JS takes over when downloaded. If you're using React, this "taking over" can be completely seemless and invisible to the user. It's also possible with this approach to write an app that works entirely without JS. See the [prerendered-html-files example](https://github.com/HenrikJoreteg/hjs-webpack/tree/master/examples/prerendered-html-files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seemless/seamless in "If you're using React, this "taking over" can be completely seemless and invisible to the user."
Looks good, but I think we should remove hjs-dev-server. Webpack already allows you to specify devserver config from webpack.config.js (http://webpack.github.io/docs/webpack-dev-server.html#cli). I think hjs-wepback should just prefill those (hot/history-api) and extend any extra options you pass in, and use webpack-dev-server as a peer dep. That way I can toggle that config from the cli/webpack config as I see fit, and not have to wonder what hjs-dev-server is doing. |
added changelog: https://github.com/henrikjoreteg/hjs-webpack#changelog and published as |
major improvement to docs
unified configuration
adding ability to pass html to defaultTemplate
now including babel proper by default
add warning/prep for peerDependency deprecation
would love some feedback on this from @lukekarrys and @latentflip <3