Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the play/pause as its own option in the preferences #278

Closed
WebVeteran opened this issue Sep 28, 2016 · 5 comments
Closed

Separate the play/pause as its own option in the preferences #278

WebVeteran opened this issue Sep 28, 2016 · 5 comments

Comments

@WebVeteran
Copy link

@paullj1 - thank you for your recent contributions! I'd like to make a request.
Separate the play/pause as its own option in the preferences. This way users can have the song artwork not be obscured.
Maybe have the play/pause only show on hover? That might work nicely.
screen shot 2016-09-28 at 10 47 58 am

paullj1 added a commit to paullj1/Hermes that referenced this issue Sep 29, 2016
 - Uses shadow effect proposed by @nriley
 - New option specifies whether or not to show play/pause state over
   top of album art.
@paullj1
Copy link
Collaborator

paullj1 commented Sep 29, 2016

Done! So it looks like hover might be possible, but I'm wondering what the use case for that would be. The only time I could think of wanting to know play/pause information would be without actually putting my cursor over top of the image (because in that case, I could just click on the icon and get that info and more).

@WebVeteran
Copy link
Author

Thank you Paul! I would contribute myself, but I only do web based programming.

Sometimes there are very quiet parts of songs, and I have my speakers on very low already... so I guess the idea is anti anxiety... is it paused? did my cable go out? etc. A quick mouse over would tell me if it's playing or not.
But not having the icon on the artwork at all - that's awesome enough!

I have other ideas... should I make new Issues for them?

@paullj1
Copy link
Collaborator

paullj1 commented Sep 29, 2016

Gotcha. I can play around with it. Might not be right away though.

Yup, individual feature requests should be created as separate issues.

paullj1 added a commit to paullj1/Hermes that referenced this issue Nov 20, 2016
 - Uses shadow effect proposed by @nriley
 - New option specifies whether or not to show play/pause state over
   top of album art.
paullj1 added a commit that referenced this issue Nov 25, 2016
@nriley
Copy link
Contributor

nriley commented Jan 14, 2017

Cleaned this up a bit in 4da4f52 (don't forget that 10.10 has different font metrics!). I think this is basically done, and the issue can be closed.

@nriley nriley closed this as completed Jan 14, 2017
@paullj1
Copy link
Collaborator

paullj1 commented Jan 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants