Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user.canSubscribe method code 1000, "An unexpected error occurred… #298

Merged
merged 1 commit into from
Mar 25, 2017

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Mar 24, 2017

…" error

Several users (including myself) experience an issue where Pandora API user.canSubscribe method throws error with code 1000 and message "An unexpected error occurred".
user.canSubscribe method is called in checkSubscriberStatus function, the sole purpose of which is to determine whether the user is a subscriber.

It is possible to get the same information just by passing additional parameter returnIsSubscriber: true in auth.userLogin, which is called before checkSubscriberStatus anyway.

I have removed checkSubscriberStatus function (which was called in 1 place only) and replaced the functionality of getting subscriber status by passing additional parameter returnIsSubscriber: true in auth.userLogin.

Tested with both free and paid accounts.

Please let me know if you need me to do anything else.

This is my first pull request, so I am sorry if I missed anything.

@nriley
Copy link
Contributor

nriley commented Mar 25, 2017

Thanks! Will try to get to it this weekend.

@nriley nriley merged commit 8d11013 into HermesApp:master Mar 25, 2017
@nriley
Copy link
Contributor

nriley commented Mar 25, 2017

I've made a beta release; let me know if it still works :-)

@yerke
Copy link
Contributor Author

yerke commented Mar 26, 2017

Works fine. Thanks

@yerke yerke deleted the FixUserCanSubscribeError branch August 28, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants