-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image animation #42
Comments
it looks off |
check #31, might have to do with the zPosition. |
@JustinM1 it didn't help. could i please Skype with you to show you |
@JustinM1 I'm using this with dynamic cells, and the animation is not working properly if i set it with dynamic cells. I tried using the basic hero animation from your project in mine, but how would i use hero with dynamic cells |
@jackpaster Are you still having this problem. I got time today, I can take a look at your problem. |
Close due to inactivity. |
@lkzhao Yes I am could you please take a look at it |
@lkzhao sorry I couldn't talk to you sooner, I was away |
Can you post a screenshot or upload a example project? Others might be able to benefit if they experiences the same problem. |
@lkzhao sure, I'm still away on vacation with my family, and I will have access to my computer tomorrow. Is it fine if I post the example project tomorrow. |
@lkzhao Thank you so much, I've been struggling with this problem for a month now and I've had no solution |
Yes, no rush.
…On Sun, Feb 5, 2017 at 11:21 AM jackpaster ***@***.***> wrote:
@lkzhao <https://github.com/lkzhao> sure, I'm still away on vacation with
my family, and I will have access to my computer tomorrow. Is it fine if I
post the example project tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADNEatkE6jjROhVYDxVoVbUQePiR0_z9ks5rZfbVgaJpZM4LkGWz>
.
|
@lkzhao Thank you |
@lkzhao I am so sorry, my flight was delayed and I only got back last night. I will send it to you by tonight. I hope I didn't scare you off from helping me. Thanks hope you understand |
Yea np |
@lkzhao How should i show it to you. Do you want me to email the project to you or what should I do. |
Upload it to github and sent me the link would be the best way.
…On Thu, Feb 9, 2017 at 12:28 AM jackpaster ***@***.***> wrote:
@lkzhao <https://github.com/lkzhao> How should i show it to you. Do you
want me to email the project to you or what should I do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADNEajiyyHRgGrZknwFzDnL4C_xTecbzks5raqPjgaJpZM4LkGWz>
.
|
Example.zip |
@lkzhao the project is up. Would you like me to take a video about the cell animation of it shrinking and expansion to a detail view controller, to show exactly what I'm talking about. |
What do you think about skyping and did you take a look at the project
…On Thursday, February 9, 2017, Luke Zhao ***@***.***> wrote:
Upload it to github and sent me the link would be the best way.
On Thu, Feb 9, 2017 at 12:28 AM jackpaster ***@***.***
***@***.***');>> wrote:
> @lkzhao <https://github.com/lkzhao> How should i show it to you. Do you
> want me to email the project to you or what should I do.
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#42 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/
ADNEajiyyHRgGrZknwFzDnL4C_xTecbzks5raqPjgaJpZM4LkGWz>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARCMmZLVttjgQDPjviP-UGcNo4j9B5ZKks5razPTgaJpZM4LkGWz>
.
|
Yes, I have. Unfortunately I couldn't skype with you. It is a bit inconvenient. For the expanding transition, it looks weird because you have multiple views with the same For you shrink animation, you have to do some custom UIView animation. There are plenty of tutorials available online, here is one: https://www.raywenderlich.com/2454/uiview-tutorial-for-ios-how-to-use-uiview-animation I have also noticed some autolayout constraints issues in your TableViewCell2.xib. Ideally you shouldnt have fixed height constraint on cell's subviews. They should be determined by the cell's height. |
could you fix it and show me what it would look like |
ExampleTableViewController.swift // MARK: - Table view data source
override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "TablesIdentifier", for: indexPath) as! TableViewCell2
cell.Image2.heroID = "\(indexPath.item)"
return cell
}
override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
let controller = UIStoryboard(name: "Main", bundle: nil).instantiateViewController(withIdentifier: "yes23") as! ViewController2
controller.view.heroID = "\(indexPath.item)"
present(controller, animated: true, completion: nil)
} |
@pborreli @e28eta @mRs- @sgl0v @CalebeNP I have an image animation where an image inside a cell goes to fill the entire view of the view controller. Do you mind helping me. Because it almost looks like the images overlaps the image of the detail page view controller and then disappears.
The text was updated successfully, but these errors were encountered: