Easier access for other devs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha thanks, this project was done in a rush for a proof of concept. |
|
Will do more refactoring for this because when I'm reading code I'm doing this in my head anyway :) |
|
When i read code its really strange some of the conclusions i come to. Is this normal* |
|
@mRs- Can I merge what you have currently? It will be hard to merge once I made more changes to the framework. |
|
Yeah just do it. I will create new ones with more refactoring later then.
Von meinem iPhone gesendet
… Am 06.01.2017 um 01:26 schrieb Luke Zhao ***@***.***>:
@mRs- Can I merge what you have currently? It will be hard to merge once I made more changes to the framework.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to refactor methods that are really difficult to understand and I would like to dive deeper in this topic and the current setup is really hard to read. So many short hands and not a clear code style is not an easy option to come into this magic.