Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compact syntax for Q ports in Synergy LIG #155

Merged

Conversation

fgbulsoni
Copy link
Contributor

Description

This PR improves the LIG synergy example and allows the use of the compact syntax for uplink sets creation on synergy

Issues Resolved

#148

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

…tax for uplink sets creation on synergy - related to #148
@fgbulsoni
Copy link
Contributor Author

fgbulsoni commented May 19, 2017

Hey @frippe75 , this should allow for the compact syntax to be used for Q ports.
Please remember to update the oneview-sdk gem to the latest version available (currently 4.4.0) when trying to use this and let me know if you run into issues.
Cheers! :octocat: 🎉

CHANGELOG.md Outdated
### Version highlights:
1. Major refactor on internal methods. Improved idempotency, logging project-wide and reduced lines of code count.
2. Raised 'oneview-sdk' version used to ~4.4.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To "approximately 4.4"? Did you mean "~> 4.4" ?

Copy link

@tmiotto tmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@fgbulsoni fgbulsoni merged commit 4d09004 into master May 22, 2017
@fgbulsoni fgbulsoni deleted the enhancement/support-compact-syntax-for-synergy-qports branch May 22, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants