Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage pool - Tested with latest api versions #228

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Storage pool - Tested with latest api versions #228

merged 3 commits into from
Mar 2, 2020

Conversation

sijeesh
Copy link
Collaborator

@sijeesh sijeesh commented Feb 24, 2020

Description

Tested storage pool resource with the latest API versions 800, 1000 and 1200

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

soodpr
soodpr approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@soodpr soodpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

madhav-bharadwaj
madhav-bharadwaj approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@madhav-bharadwaj madhav-bharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. If we are updating copyright in lib files, should the spec files also be updated?

@sijeesh
Copy link
Collaborator Author

sijeesh commented Mar 2, 2020

@madhav-bharadwaj , I think we don't have to update the copyright if we are not modifying the file.
Let me keep the lib file copyright as it is.
Thanks for pointing out this.

@sijeesh sijeesh merged commit f55d5cf into master Mar 2, 2020
@sijeesh sijeesh deleted the api/1200/storage_pool branch March 2, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soodpr soodpr soodpr approved these changes

@madhav-bharadwaj madhav-bharadwaj madhav-bharadwaj approved these changes

@AnushaY1916 AnushaY1916 Awaiting requested review from AnushaY1916

@dileepds dileepds Awaiting requested review from dileepds

@jyothisgm jyothisgm Awaiting requested review from jyothisgm

@Sowmyahsg Sowmyahsg Awaiting requested review from Sowmyahsg

@supreethpy supreethpy Awaiting requested review from supreethpy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sijeesh @madhav-bharadwaj @soodpr