Infrastructure Demo with storage components #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyothisgm
requested changes
Apr 16, 2020
| } | ||
| } | ||
|
|
||
| oneview_storage_system{'storage_system_1': |
There was a problem hiding this comment.
Follow a uniform naming convention. Since you are using Test * *. Please follow the same throughout.
There was a problem hiding this comment.
You can use any naming convention. Just make it uniform. Don't mix underscore lower case uppercase, camel, together
| } | ||
| } | ||
|
|
||
| # Creates EnclosureGroup using LIG created above |
There was a problem hiding this comment.
Do not abbreviate resource names in comments
soodpr
reviewed
Apr 16, 2020
soodpr
reviewed
Apr 23, 2020
| data => | ||
| { | ||
| name => 'Test Server Profile Create', | ||
| serverHardwareUri => '/rest/server-hardware/30303437-3034-4D32-3230-313030304752', |
There was a problem hiding this comment.
can you check if you can use name instead of uri
soodpr
reviewed
Apr 23, 2020
|
|
||
| # This example works for api_variant "Synergy" | ||
| # Create FC Network | ||
| oneview_fc_network{'Test Puppet FC Network Create1': |
There was a problem hiding this comment.
again not seeing this use in the demo here
soodpr
reviewed
Apr 23, 2020
| } | ||
| } | ||
|
|
||
| # Creates ServerProfile |
There was a problem hiding this comment.
whats the need of creating this server profile?
soodpr
reviewed
Apr 23, 2020
soodpr
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Infrastructure Demo with storage components
Issues Resolved
NA
Check List
$ rake test).