Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix remove extra unmanaged volume #172

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Bugfix remove extra unmanaged volume #172

merged 4 commits into from
Feb 22, 2017

Conversation

aalexmonteiro
Copy link
Contributor

@aalexmonteiro aalexmonteiro commented Feb 13, 2017 •
edited by jsmartt
Loading

Description

When we call ::remove_extra_unmanaged_volume of VolumeAttachment resource.

Issues Resolved

Fixes #112

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@aalexmonteiro aalexmonteiro changed the title Bugfix/remove extra unmanaged volume Bugfix remove extra unmanaged volume Feb 13, 2017
@aalexmonteiro
Copy link
Contributor Author

@fgbulsoni , @tmiotto , @jsmartt can you also review this? Please!

jsmartt
jsmartt approved these changes Feb 22, 2017
View reviewed changes
Copy link
Collaborator

@jsmartt jsmartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@aalexmonteiro
Copy link
Contributor Author

Thanks @jsmartt .

@aalexmonteiro aalexmonteiro merged commit af5db47 into master Feb 22, 2017
@aalexmonteiro aalexmonteiro deleted the bugfix/remove_extra_unmanaged_volume branch February 22, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardogpsf ricardogpsf ricardogpsf approved these changes

@jsmartt jsmartt jsmartt approved these changes

Assignees
No one assigned
Labels
API200 API300 bug/bug-fix C7000 Synergy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalexmonteiro @ricardogpsf @jsmartt