Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-137: Modify enumerate to account for option maxRuns #138

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Issue-137: Modify enumerate to account for option maxRuns #138

merged 2 commits into from
Sep 23, 2022

Conversation

rsk2
Copy link
Contributor

@rsk2 rsk2 commented Sep 22, 2022

For #137

@rsk2 rsk2 mentioned this pull request Sep 22, 2022
Closed
@Hexagon
Copy link
Owner

Hexagon commented Sep 22, 2022

Cool! Could you have a look at https://github.com/Hexagon/croner/blob/master/test/node/js/src/suites/options.cjs and add a test case that cover this change?

@rsk2
Copy link
Contributor Author

rsk2 commented Sep 23, 2022

Cool! Could you have a look at https://github.com/Hexagon/croner/blob/master/test/node/js/src/suites/options.cjs and add a test case that cover this change?

@Hexagon, I have added it.

@Hexagon
Copy link
Owner

Hexagon commented Sep 23, 2022

Great 💯

This will be included in next release

@Hexagon Hexagon merged commit 489856e into Hexagon:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexagon Hexagon Hexagon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsk2 @Hexagon