Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Open button #177

Open
ssssank opened this issue Jul 11, 2023 · 12 comments
Open

Rename the Open button #177

ssssank opened this issue Jul 11, 2023 · 12 comments
Assignees
@nuuska-muikkunen
Labels
good first issue Good for newcomers task

Comments

@ssssank
Copy link
Contributor

ssssank commented Jul 11, 2023 •
edited by Maxonquall
Loading

Problem description

It is unclear what the Open button does in the sent typo

Proposed solution

Since this button translates the typo to the status "In progress", you can rename it to "Start work" or "Get started"
@ssssank ssssank added the task label Jul 11, 2023
@fey
Copy link
Collaborator

fey commented Mar 11, 2024

Актуально

@fey fey added the good first issue Good for newcomers label Mar 11, 2024
@nuuska-muikkunen
Copy link
Contributor

Привет!
Я заканчиваю курс и хочу попробовать смогу ли разобраться в коде.

@fey
Copy link
Collaborator

fey commented Mar 15, 2024

Да, берите.

@nuuska-muikkunen
Copy link
Contributor

nuuska-muikkunen commented Mar 20, 2024 •
edited
Loading

Имя кнопки OPEN определяется именем константы OPEN перечисления TypoEvent. В зависимости от этих констант (OPEN, RESOLVE, REOPEN, CANCEL) меняется статус переданной опечатки, задается имя кнопки и ее цвет.

  1. Будем переименовывать OPEN в START WORK (я бы лучше переименовал просто в START)?
  2. Надо ли, следуя нашей логике, переименовать константу REOPEN в RESTART (RESTART WORK)?
  3. Имена методов тестирования тоже переименовывать (patchTypoEventOpenToReported и patchTypoEventReopenToCanceled)?
  4. Русский вариант тоже меняю - НАЧАТЬ (НАЧАТЬ РАБОТУ), ПЕРЕДЕЛАТЬ - перевод для RESTART?

PS Спрашиваю, поскольку у меня это первый опыт работы с незнакомым кодом.

@fey
Copy link
Collaborator

fey commented Mar 21, 2024

@Malcom1986 поможешь нам?
Скорее всего по коду тоже нужно поменять, ведь у нас и смыслы меняются.

@Malcom1986
Copy link
Collaborator

@nuuska-muikkunen Приветствую. Давайте сами состояния трогать не будем, оставим как есть. Они довольно семантично называются. Поменяем только надпись на кнопке, сделаем ее более юзер френдли

@nuuska-muikkunen
Copy link
Contributor

Состояния не трогаю. Только названия ивентов, от которых названия кнопок определяются.
Вместо OPEN - START, вместо REOPEN - RESTART.
На русском: вместо ОТКРЫТЬ - НАЧАТЬ, вместо ОТКРЫТЬ ЗАНОВО - НАЧАТЬ СНОВА.

@nuuska-muikkunen
Copy link
Contributor

Вот так выглядят новые кнопки (см прилагаемые скринки экранов с локального запуска приложения).
result of screens issue #177 button OPEN rename.pdf
Можно коммитить? Изменения в отдельной ветке.

@fey
Copy link
Collaborator

fey commented Mar 21, 2024

Вы можете запушить в свою ветку и создать пулл реквест
https://www.youtube.com/watch?v=pUT3mx1ZRUM
Пока ПР не принят, в него можно спокойно вносить изменения. При принятии ПРа будут приняты изменения на момент принятия. Скрин не могу посмотреть, он в формате ПДФ. Лучше задеплойте демо и скиньте ссылку на посмотреть.

nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] rename TypoEvent constants to change buttons names
9c0dedc
@nuuska-muikkunen
Copy link
Contributor

Деплой не проходит. У вас Dockerfile не менялся 9 месяцев и все про Maven, а POM file убрали при миграции на gradle. Я правильно понял?

nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] rename TypoEvent constants to change buttons names
bc3bfb1
@Malcom1986
Copy link
Collaborator

Да, здорово будет, если и докерфайл поправите заодно. Можно в Procfile подглядывать, как мы заускаем приложение на хероку

nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] changed Dockerfile for gradle
f26aab3
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] correct gradle task in Dockerfile
d35fd36
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] fix
8d36d46
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] back to installDist
78cf3a0
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] run build without test Task
7b82371
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] set main class attribute for jar
6ed51da
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] clean before build
b07913b
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 22, 2024
@nuuska-muikkunen
[Hexlet#177] upgrade dependencies
bac8088
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 23, 2024
@nuuska-muikkunen
[Hexlet#177] use Makefile command to run application
abee3ce
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 23, 2024
@nuuska-muikkunen
[Hexlet#177] use gradlew to run application
4fb514b
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 23, 2024
@nuuska-muikkunen
[Hexlet#177] run in production mode
4dbf7e7
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 24, 2024
@nuuska-muikkunen
[Hexlet#177] return to build/libs/ bootJar
8207a79
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 24, 2024
@nuuska-muikkunen
Merge remote-tracking branch 'origin/ISSUE-#177-Rename-button-OPEN' i…
5368dee 
…nto ISSUE-Hexlet#177-Rename-button-OPEN

# Conflicts:
#	Dockerfile
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 24, 2024
@nuuska-muikkunen
[Hexlet#177] clean gradle config and explicitly define jar file name
912d567
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 24, 2024
@nuuska-muikkunen
[Hexlet#177] define production profile
f0be9cb
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 24, 2024
@nuuska-muikkunen
[Hexlet#177] remove PORT if empty
91af6c1
@nuuska-muikkunen
Copy link
Contributor

Наконец победил деплой :-)
Можете смотреть результат https://hexlet-correction-rqc5.onrender.com/.
У меня требуется VPN для работы.

nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 27, 2024
@nuuska-muikkunen
[Hexlet#177] leave event names unchanged (just buttons renaming)
5cc0eff
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 28, 2024
@nuuska-muikkunen
[Hexlet#177] reduce Dockerfile
8f4ba53
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 28, 2024
@nuuska-muikkunen
[Hexlet#177] set alpine image
7556069
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 28, 2024
@nuuska-muikkunen
[Hexlet#177] set jammy image
415e2bb
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 28, 2024
@nuuska-muikkunen
[Hexlet#177] add platform and tag
d169b38
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Mar 29, 2024
@nuuska-muikkunen
[Hexlet#177] remove test line in README file
f4302b8
Malcom1986 added a commit that referenced this issue Apr 3, 2024
@Malcom1986
Merge pull request #239 from nuuska-muikkunen/ISSUE-#177-Rename-butto…
17d7966 
…n-OPEN

[#177] rename TypoEvent constants to change buttons names
nuuska-muikkunen added a commit to nuuska-muikkunen/hexlet-correction that referenced this issue Apr 20, 2024
@nuuska-muikkunen
[Hexlet#177] remove delete button with the controller, service and th…
fc8ea11 
…e related test methods
@Maxonquall Maxonquall mentioned this issue Jul 24, 2024
Open
@fey fey changed the title Переименовать кнопку Open Rename the Open button Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuuska-muikkunen nuuska-muikkunen

Labels
good first issue Good for newcomers task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fey @ssssank @Malcom1986 @nuuska-muikkunen