-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beam Spin tracking #1071
Merged
MaxThevenet
merged 19 commits into
Hi-PACE:development
from
AlexanderSinn:spin_tracking
Mar 13, 2024
Merged
Add Beam Spin tracking #1071
MaxThevenet
merged 19 commits into
Hi-PACE:development
from
AlexanderSinn:spin_tracking
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_for_runtime_components' into spin_tracking
ax3l
reviewed
Mar 12, 2024
MaxThevenet
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Just left 1 comment in the code.
I added the register usage for GPU to the PR description. |
MaxThevenet
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison with FBPIC:
The non-zero sy and sz mean in FBPIC are caused by the random fluctuations of the Gaussian beam. In HiPACE++ this was suppressed with
beam.do_symmetrize = true
.Add spin tracking from fbpic/fbpic#672.
This PR fixes #1027 and is based on #1069, #1068, #1067 and #1066.
Register usage for the beam pusher in development, the high local memory usage is caused by the kernels that use the parser for external fields.
PR:
const
isconst
)