Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming for pseudo-potential on plasma particles #140

Merged
merged 8 commits into from
Sep 2, 2020

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Sep 1, 2020

This PR resolves issue #100.

Previously, the pseudo-potential at the particle position psi actually stood for psi + 1.
Now, psi actually represents psiand the 1 was added where needed (or in one case, removed).

Additionally, the field component Psi actually stood for -Psi. This was fixed, now it actually stands for Psi.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the cleaning Code cleaning, avoid duplication, better naming, better style etc. label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants