Add reconstruction classes for simulated events. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATM simulated events are treated equal to ESD events: The same reconstruction classes are used. This philosophy has lead to many painful errors. Simulated events have simulated meta-data (e.g. detector- and station timing-offsets) that cannot be retrieved from the public database. However, simulated events share much of the meta-data with ESD events (e.g. station numbers, station- and cluster layouts). This results in mix-up. This creates: ReconstructSimulatedEvents() ReconstructSimulatedCoincidences() which read meta-data from cluster objects stored in HDF5 files, instead of using the public database.
kaspervd
previously approved these changes
Nov 14, 2017
153957
requested changes
Nov 14, 2017
sapphire/analysis/reconstructions.py
Outdated
| # TODO: check cluster object isinstance | ||
| if self.verbose: | ||
| print('Using cluster %s for metadata.' % self.cluster) | ||
| return cluster |
There was a problem hiding this comment.
Use one return cluster after the if…else.
sapphire/analysis/reconstructions.py
Outdated
| """ | ||
|
|
||
| def _get_or_create_station_object(self, station): | ||
| """Read object from HDF5 file.""" |
sapphire/analysis/reconstructions.py
Outdated
| # TODO: check cluster object | ||
| if self.verbose: | ||
| print('Using cluster %s for metadata.' % self.cluster) | ||
| return cluster |
There was a problem hiding this comment.
Here also one return cluster after the if…else.
| dir_path = os.path.dirname(__file__) | ||
| return os.path.join(dir_path, fn) | ||
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
Place tearDown method immediately after setUp method.
|
I pushed the requested changes. I do not intend to fix the codecov/patch failure. @153957 please let me know if this is OK. Especially the docstrings might still require some work. |
153957
approved these changes
Nov 20, 2017
|
Thanks @153957! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM simulated events are treated equal to ESD events: The same reconstruction
classes are used.
This philosophy (although it has many benefits) also has lead to many painful errors. Simulated events have simulated meta-data (e.g. detector- and station timing-offsets) that cannot be retrieved from the public database. However, simulated events share much of the meta-data with ESD events (e.g. station numbers, station- and cluster layouts). This results in mix-up.
Recently this mix-up also happened on pique. This created the need to change this.
This creates:
ReconstructSimulatedEvents()
ReconstructSimulatedCoincidences()
which read meta-data from cluster objects stored in HDF5 files, instead of using
the public database.
This includes basic tests. Reading cluster objects was not tested at all, this PR includes some basic tests.