Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes #60

Merged
merged 5 commits into from
Jan 29, 2024
Merged

some fixes #60

merged 5 commits into from
Jan 29, 2024

Conversation

cutebear0123
Copy link
Contributor

@cutebear0123 cutebear0123 commented Jan 6, 2024 •
edited
Loading

1.修復特定emoji無法/react
2.禁止@ everyone
3.把2.和邀請連結那加上log
4.改用removeMd，因為不能@ everyone了所有沒差

@cutebear0123 cutebear0123 marked this pull request as ready for review January 6, 2024 01:10
@kyometori kyometori added bug Something isn't working enhancement New feature or request labels Jan 6, 2024
@kyometori
Copy link
Member

ban words 我覺得允許放 regex 比較好，把裡面的字串轉成 regex 然後檢查，類似 banwords.map(s => new RegExp(s)).some(r => r.test(content)) 之類的，看怎麼寫比較好。這樣就可以放回之前那個 regex 了（除非他有什麼問題）。

kyometori
kyometori requested changes Jan 20, 2024
View reviewed changes
Copy link
Member

@kyometori kyometori left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你這個 reformat 真的超煩
DontReformatCodeInFeaturePR

src/classes/WebhookLogger.ts Outdated Show resolved Hide resolved
src/classes/WebhookLogger.ts Outdated Show resolved Hide resolved
src/classes/HZNetwork.ts Outdated Show resolved Hide resolved
@Zollo757347
Copy link
Member

建議把 checkMessageSafe 改名成 checkMessageBanned 或 isBannedMessage，現在函式名稱和他實際做的事是相反的。另外這個函式理論上不應該被外面存取，所以改成 private 會比較好。

@kyometori
Copy link
Member

我投 isBannedMessage 一票

@cutebear0123
Copy link
Contributor Author

我回家改 (aka soon ™️

@kyometori kyometori self-requested a review January 23, 2024 18:56
@Zollo757347 Zollo757347 merged commit 91491b7 into HiZollo:dev Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zollo757347 Zollo757347 Zollo757347 approved these changes

@kyometori kyometori kyometori approved these changes

Assignees

@cutebear0123 cutebear0123

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cutebear0123 @kyometori @Zollo757347