Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wardrobe Improvements (2.4.0) #111

Merged
merged 30 commits into from
May 25, 2023
Merged

Wardrobe Improvements (2.4.0) #111

merged 30 commits into from
May 25, 2023

Conversation

LoJoSho
Copy link
Member

@LoJoSho LoJoSho commented May 23, 2023

Select the option(s) that best describes this PR:

  • Major breaking change
  • Minor change
  • Feature implementation
  • Bug fix
  • Chore (Changes that don't fix or add new features and don't modify source files)
  • Refactoring (Changes that dont't fix or add new features but do modify source files)
  • Documentation (Changes to README files and/or JavaDocs)
  • Style (Changes that don't affect the meaning of the code)
  • Performance
  • Other (Please specify below)

Please describe the changes this PR makes and why it should be merged:

This PR adds the ability to create multiple wardrobes within the configuration file that otherwise had to be done through third-party plugins. This also adds more customization to wardrobes, including the ability to add permissions to wardrobes, per wardrobe distances, etc.

This also updates all the commands to support wardrobe names as well as other places that required it. This also adds the wardrobe to PlayerWardrobeEnterEvent. WorldGuard Wardrobe flags will need to be updated, as it has been changed from a StateFlag to a StringFlag.

Command Changes:
/cosmetic wardrobe -> /cosmetic wardrobe id
/cosmetic setlocation <locationtype> -> /cosmetic setlocation <id> <locationtype>

This PR will resolve #108.

A new configuration file is shown below:

  wardrobes:
    default: # This is the wardrobe id. 
      permission: "testy.permission"
      distance: 16
      npc-location:
        world: world
        x: -101.4709725520765
        y: 137.0
        z: -44.074566746431884
        yaw: -179.70357
        pitch: 1.800333
      viewer-location:
        world: world
        x: -99.20379954967974
        y: 137.0
        z: -48.287224878314056
        yaw: 30.596544
        pitch: 9.150333
      leave-location:
        world: world
        x: -98.37955054954183
        y: 137.0
        z: -43.25851451068986
        yaw: 30.596544
        pitch: 9.150333

@LoJoSho LoJoSho added the enhancement New feature or request label May 23, 2023
@LoJoSho LoJoSho linked an issue May 23, 2023 that may be closed by this pull request
2 tasks
@LoJoSho LoJoSho linked an issue May 23, 2023 that may be closed by this pull request
2 tasks
@LoJoSho LoJoSho changed the title Multiple Wardrobes (2.4.0) Wardrobe Improvements (2.4.0) May 24, 2023
@LoJoSho LoJoSho merged commit b00c79f into remapped May 25, 2023
@LoJoSho LoJoSho deleted the multi_wardrobe branch May 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant