Fix GNOME Shell Wayland session crashing when trying to pick a color #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to have to modify it to make it work with any upcoming Wayland solution, and it has been removed from upstream master. This imported version has some deprecated API updated (more to be done) and is modified to compile with our stricter compiler flags. There are some other cleanups to be done, too (e.g. we can probably remove the separate alpha property now that it uses GdkRGBA).
Not optimal, but it at least fixes #65 until we have a solution for
color picking on Wayland.
Hjdskes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #65 by importing GtkColorSelection from GTK+ into a local widget, and making the picker button insensitive when running on Wayland.
Importing the widget has been coming for a while so we might as well fix this the right way, right away. In the importing process, I have made a few changes to the code so to make it compile with our stricter compiler flags and to remove the deprecated GdkColor API (which also allowed to remove some indirection in Gcolor3Window).
There is more deprecated API left which I plan to resolve at a later stage, and eventually I'll have to import GtkHSV as well.