New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GNOME Shell Wayland session crashing when trying to pick a color #67

merged 3 commits into from Nov 2, 2017


1 participant

Hjdskes commented Nov 2, 2017

This PR fixes #65 by importing GtkColorSelection from GTK+ into a local widget, and making the picker button insensitive when running on Wayland.

Importing the widget has been coming for a while so we might as well fix this the right way, right away. In the importing process, I have made a few changes to the code so to make it compile with our stricter compiler flags and to remove the deprecated GdkColor API (which also allowed to remove some indirection in Gcolor3Window).

There is more deprecated API left which I plan to resolve at a later stage, and eventually I'll have to import GtkHSV as well.

Hjdskes added some commits Nov 1, 2017

Import GtkColorSelection as Gcolor3ColorSelection
We're going to have to modify it to make it work with any upcoming
Wayland solution, and it has been removed from upstream master.

This imported version has some deprecated API updated (more to be done)
and is modified to compile with our stricter compiler flags. There are
some other cleanups to be done, too (e.g. we can probably remove the
separate alpha property now that it uses GdkRGBA).
Gcolor3ColorSelection: make picker insensitive on Wayland
Not optimal, but it at least fixes #65 until we have a solution for
color picking on Wayland.

@Hjdskes Hjdskes changed the title from Fix/wayland crash to Fix GNOME Shell Wayland session crashing when trying to pick a color Nov 2, 2017

@Hjdskes Hjdskes merged commit 8015c0e into master Nov 2, 2017

@Hjdskes Hjdskes deleted the fix/wayland-crash branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment