[Packaging] Add experimental Flatpak support #72

julianrichen · 2017-11-10T14:00:58Z

This pr adds an initial flatpak manifest and should close #71. I would recommend changing the gcolor3.svg, gcolor3.desktop, & gcolor3.appdata.xml file from gcolor.* to org.unia.gcolor3.* since flatpak automatically looks for those files based on the application id. It would also be needed since the the shell will look for org.unia.gcolor3.svg but your application will look for gcolor3.svg in the About modal window.

Things seem to be working and I added --socket=wayland but obviously because of #67 it won't work 100% on wayland. Didn't try x11 since I use wayland.

Build

flatpak --user remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
flatpak --user install flathub org.gnome.Platform//3.26
flatpak --user install flathub org.gnome.Sdk//3.26

flatpak-builder --force-clean --repo=repo gcolor3 org.unia.gcolor3.json
flatpak --user remote-add --no-gpg-verify --if-not-exists gcolor3 repo
flatpak --user install gcolor3 org.unia.gcolor3
flatpak --user update org.unia.gcolor3

flatpak run org.unia.gcolor3

Future

If you plan on following-up on #59 then you will need to add the following to finish-args:

"--env=DCONF_USER_CONFIG_DIR=.config/dconf",
"--filesystem=xdg-run/dconf",
"--filesystem=~/.config/dconf:ro",
"--talk-name=ca.desrt.dconf",

Hjdskes · 2017-11-10T14:26:49Z

Thanks! I'll take a look at this in the coming days!

Hjdskes

So those few days turned into a few months... sorry!

I have a few questions regarding some options, see below. It seems to run file, although it does not have access to ~/.rgb.ini (it creates its own in ~/.var/app/org.unia.gcolor3/config/gcolor3/config.ini) and seems to complain about DBus:

(gcolor3:3): GLib-GIO-CRITICAL **: g_dbus_proxy_new: assertion 'G_IS_DBUS_CONNECTION (connection)' failed

I'm also getting this:

(gcolor3:3): Gtk-WARNING **: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.

Do you know how to get these resolved? I'd love to have a working Flatpak up on Flathub!

Hjdskes · 2018-01-19T08:41:46Z

org.unia.gcolor3.json

+        "--socket=x11",
+        "--socket=wayland",
+
+        "--filesystem=xdg-config/gcolor3/config.ini:ro"


What is this for? The colors are written to ~/.rgb.ini, not ~/.config/gcolor/config.ini, if that's what this is.

The flatpak is based off v2.2 which has this in the changelog:

Follow the XDG directory specification (d91dd06).
This means that the configuration file has moved from ~/.rgb.ini to $XDG_CONFIG_HOME/gcolor3/config.ini

Or at least I think that was the reasoning, it's been a while since I wrote it

Whoops, you're 100% right! I forgot that PR.

Hjdskes · 2018-01-19T08:42:02Z

org.unia.gcolor3.json

+    ],
+
+    "build-options": {
+        "cflags": "-O2 -g"


Should we distribute a debug build inside the Flatpak?

Most, if not all of the flathub builds do:
https://github.com/search?q=org%3Aflathub+-g&type=Code

I'm not 100% sure why they agreed to this since flathub only accepts stable builds so it's not like you would be debugging a broken build.

Strange, but if they all do it, let's do so too.

Hjdskes · 2018-01-19T08:46:25Z

I would recommend changing the gcolor3.svg, gcolor3.desktop, & gcolor3.appdata.xml file from gcolor.* to org.unia.gcolor3.* since flatpak automatically looks for those files based on the application id. It would also be needed since the the shell will look for org.unia.gcolor3.svg but your application will look for gcolor3.svg in the About modal window.

Thanks, I'll be sure to make those changes (or you can here directly, if you will). Since my GitHub handle changed to Hjdskes, I'm planning s/unia/hjdskes/ also.

julianrichen · 2018-01-19T13:22:13Z

I would recommended releasing v2.3 before pulling this but after you do the rename. You seem to have a lot of quality of life fixes that wouldn't be included in the new flatpak sent to flathub. Also flathub doesn't accept flatpaks built from master so it needs to either be a logical "stable" commit or better yet a archive file. I would much rather change the source from git to archive with a url pointing to https://github.com/Hjdskes/gcolor3/archive/v2.2.tar.gz or similar.

Also flathub doesn't seem 100% sure what to do about apps that rename their app-id yet so they ask you don't change them after submitting. They can rename the repo but OSTree is a bit harder, so I would only submit after you s/unai/hjdskes/.

Hjdskes · 2018-01-19T13:52:04Z

Re v2.3, definitely on the planning. Time is the # 1 problem for me at the moment.

Also flathub doesn't accept flatpaks built from master so it needs to either be a logical "stable" commit or better yet a archive file.

Does what you did in 66147fe work for you, or do we need to switch to branches for releases?

julianrichen · 2018-01-19T14:57:44Z

You just need to change the url to v2.3 or whichever version you are planning to upgrade to and generate a new sha256 checksum.

We could also have the local flatpak file point to the master branch for nightly testing and submit a stable version to flathub. I found developing using flatpak in GNOME Builder to be very nice since the builds are reproducible and independent from the current system.

Their might be some issue atm since the app-id passed into GApplicaition is the old one. I was writing another commit to change all the app-ids but ran into a linker issue and had to bolt to classes. I have some before class so I'm going to look into it.

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

Hjdskes · 2018-01-24T20:21:33Z

I did the rename in https://github.com/Hjdskes/gcolor3/tree/rename, which currently is on top of this branch so I can easily test the Flatpak. Compiling and running works locally (i.e. not inside a Flatpak), however when rebuilding the Flatpak (with hjdskes instead of unia, of course) I get the following:

** (gcolor3:3): WARNING **: Error writing file: Failed to rename file ?/home/jente/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini.VVREDZ? to ?/home/jente/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini?: g_rename() failed: Device or resource busy

I am not sure if this is related to the renaming. Can you test this @julianrichen?

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

julianrichen · 2018-01-25T00:22:26Z

It's building fine for me but I can't run it, probably because of some permissions with the color.ini

** (gcolor3:2): WARNING **: Error opening file: No such file or directory. Colors likely won't be saved
Failed to register: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

@Hjdskes Try deleting your .flatpak-builder directory, which is located in the directory you built the flatpak. I know OSTree has some issue with app-id renaming which is why flathub deson't want to change them after they are committed. That might be the reason.

julianrichen · 2018-01-25T00:25:09Z

Oh... I set config.ini to :ro (read-only), probably should be :rw (read-write).

Allow read-write access to xdg-config/gcolor3/config.ini, instead of read-only.

Hjdskes · 2018-01-25T08:14:42Z

It built fine for me as well, but I got another error, even after rebuilding with the rw permissions:

** (gcolor3:3): WARNING **: Error writing file: Failed to rename file ?/home/jente/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini.93SADZ? to ?/home/jente/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini?: g_rename() failed: Device or resource busy

I'm not sure what's going on here. EDIT: This does not seem to happen on your branch, without the renaming.

julianrichen · 2018-01-25T12:32:21Z

Weird, I still get

** (gcolor3:2): WARNING **: Error opening file: No such file or directory. Colors likely won't be saved
Failed to register: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

Which is only a warning and should not stop the application from running...

Question, when you build locally are you changing the manifest to build the local files instead of pulling the v2.2 archive? Example:

     ...
    "modules": [
        {
            "name": "gcolor3",
            "sources": [
                {
                    "type": "git",
		    "url": "file:///home/jente/Projects/gcolor3"
                }
            ]
        }
    ]
}

julianrichen · 2018-01-25T12:46:05Z

I built the packages outside of flatpak using the rename branch and it builds fine and runs but I also get the following:

** (gcolor3:15690): WARNING **: Error reading keys: Key file does not have group “Colors”

After I built without flatpak and re-ran the flatpak run ... I'm now getting the same message as you:

Failed to register: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

** (gcolor3:2): WARNING **: Error writing file: Failed to rename file “/home/julian/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini.BOMEDZ” to “/home/julian/.var/app/org.hjdskes.gcolor3/config/gcolor3/config.ini”: g_rename() failed: Device or resource busy

Which is strange, idk if it's a delay thing & a coincident because only stuff inside the flatpak should effect the flatpak.

Still looking into it.

julianrichen · 2018-01-25T13:04:16Z

So changing

"--filesystem=xdg-config/gcolor3/config.ini"

to

"--filesystem=home"

Fixed the warning, I then tried

"--filesystem=xdg-config/gcolor3/"

and it removed the warning, I think because you have a function that checks that the .config/gcolor3 directory exists. ensure_user_dir()

I still can't get the application to launch, the dbus warning makes it seem like their is an application mismatch in GApplication...

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

Hjdskes · 2018-02-25T16:11:25Z

I got everything to work by using --filesystem=xdg-config/gcolor3:rw and actually building from the rename branch. I'll go ahead and merge that now, thank you for taking the initiative and helping solve the issues we ran into!

bilelmoussaoui · 2018-02-25T16:47:10Z

@Hjdskes Can you push the flatpak file to flathub too? Thanks

Hjdskes · 2018-02-25T17:24:24Z

I will do that once I release a new version that I can point the manifest to. According to @julianrichen, Flathub does not accept Flatpaks that build from master, understandably so.

[Packaging] Add experimental Flatpak support

5d5d654

Hjdskes reviewed Jan 19, 2018

View reviewed changes

[flatpak] Update source

66147fe

Hjdskes added a commit that referenced this pull request Jan 24, 2018

Add org.hjdskes. prefix to gcolor3.{svg,desktop,appdata.xml}

5361910

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

Hjdskes added a commit that referenced this pull request Jan 24, 2018

Add org.hjdskes. prefix to gcolor3.{svg,desktop,appdata.xml}

db91a18

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

[flatpak] Make config.ini read-write

5b6d604

Allow read-write access to xdg-config/gcolor3/config.ini, instead of read-only.

Hjdskes added a commit that referenced this pull request Feb 25, 2018

Add org.hjdskes. prefix to gcolor3.{svg,desktop,appdata.xml}

0e625c4

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

Hjdskes added a commit that referenced this pull request Feb 25, 2018

Add org.hjdskes. prefix to gcolor3.{svg,desktop,appdata.xml}

07b3728

To follow GNOME standards and to prevent necessary renaming in the Flatpak manifest (see #72).

Hjdskes closed this Feb 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Packaging] Add experimental Flatpak support #72

[Packaging] Add experimental Flatpak support #72

julianrichen commented Nov 10, 2017

Hjdskes commented Nov 10, 2017

Hjdskes left a comment

Hjdskes Jan 19, 2018

julianrichen Jan 19, 2018

Hjdskes Jan 19, 2018

Hjdskes Jan 19, 2018

julianrichen Jan 19, 2018

Hjdskes Jan 19, 2018

Hjdskes commented Jan 19, 2018

julianrichen commented Jan 19, 2018

Hjdskes commented Jan 19, 2018 •

edited

Loading

julianrichen commented Jan 19, 2018

Hjdskes commented Jan 24, 2018

julianrichen commented Jan 25, 2018 •

edited

Loading

julianrichen commented Jan 25, 2018

Hjdskes commented Jan 25, 2018 •

edited

Loading

julianrichen commented Jan 25, 2018

julianrichen commented Jan 25, 2018

julianrichen commented Jan 25, 2018

Hjdskes commented Feb 25, 2018

bilelmoussaoui commented Feb 25, 2018

Hjdskes commented Feb 25, 2018

[Packaging] Add experimental Flatpak support #72

[Packaging] Add experimental Flatpak support #72

Conversation

julianrichen commented Nov 10, 2017

Build

Future

Hjdskes commented Nov 10, 2017

Hjdskes left a comment

Choose a reason for hiding this comment

Hjdskes Jan 19, 2018

Choose a reason for hiding this comment

julianrichen Jan 19, 2018

Choose a reason for hiding this comment

Hjdskes Jan 19, 2018

Choose a reason for hiding this comment

Hjdskes Jan 19, 2018

Choose a reason for hiding this comment

julianrichen Jan 19, 2018

Choose a reason for hiding this comment

Hjdskes Jan 19, 2018

Choose a reason for hiding this comment

Hjdskes commented Jan 19, 2018

julianrichen commented Jan 19, 2018

Hjdskes commented Jan 19, 2018 • edited Loading

julianrichen commented Jan 19, 2018

Hjdskes commented Jan 24, 2018

julianrichen commented Jan 25, 2018 • edited Loading

julianrichen commented Jan 25, 2018

Hjdskes commented Jan 25, 2018 • edited Loading

julianrichen commented Jan 25, 2018

julianrichen commented Jan 25, 2018

julianrichen commented Jan 25, 2018

Hjdskes commented Feb 25, 2018

bilelmoussaoui commented Feb 25, 2018

Hjdskes commented Feb 25, 2018

Hjdskes commented Jan 19, 2018 •

edited

Loading

julianrichen commented Jan 25, 2018 •

edited

Loading

Hjdskes commented Jan 25, 2018 •

edited

Loading