-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove workaround for coq/coq#8994 #1807
base: master
Are you sure you want to change the base?
remove workaround for coq/coq#8994 #1807
Conversation
What about the other fields that still have primed versions? |
Actually that's a good point. I've only addressed one. I'll draft this for now and make sure I've got them all. Well, specifically about that bug anyway. I need to think a bit more about why we still have primed fields in CatEquiv. |
(Just to be clear, I meant the other fields of the same Class.) |
I tried removing the primes in the other fields and got the wildcat library working, however Coq gets stuck on the Not sure what is going on there. I'll keep my changes and submit in a PR after this is merged if you want to take a closer look. |
I guess the issue is the one explained in a comment: I think it's fine to merge this to at least get rid of one redefinition. |
I also had a go at removing InO_internal from ReflectiveSubuniverse but I was not successful. |
Rebasing this breaks |
- fixes HoTT#1541 Signed-off-by: Ali Caglayan <alizter@gmail.com>
5b53a31
to
cc98084
Compare
This changed the behaviour of resolution in a few places, but nothing a quick modification to the proof wouldn't fix.