-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite CI scripts #1102
Rewrite CI scripts #1102
Conversation
884cd3c
to
d85e18a
Compare
1452961
to
c89439e
Compare
1a2ad93
to
701ef32
Compare
c765d06
to
e90308a
Compare
Updates: the
When viewed in a browser (not via command line tools), the user will be redirected to the real PDFs, such as https://hott.github.io/book/hott-online-1319-g54f404d.pdf. I dropped the "nightly" in the URLs but it's easy to put it back. |
Some areas for improvements that I intend NOT to address in this PR:
|
Nice! Is this ready to merge? I don't suppose there's any way for the redirecting URLs to end in .pdf without the extra .html. Did we ever support DVIs? I don't remember ever offering them for download. Does it really matter how long the build takes? It only needs to be run when new changes are merged into the repository, which is quite infrequent. |
Yes. We can just merge it now!
We check whether
It's mostly my perfectionism kicking in. Currently, the CI will also be run for every new commit in a pull request (but then the script will not push any changes to the website or the wiki unless it's run on the |
Thank you very much for doing this!! |
Sorry I somehow missed this. It's actually already working. You can drop the Currently, these two are the same: |
Can we do something to prevent these actions from trying to run on forks? |
or something should do that. You will probably have to put a step in each workflow to exit early if it is the wrong owner. |
We can attach an |
I think it makes sense to compile the book on pushes to forks, but not to try to update any posted versions. I just pulled from upstream and pushed to my fork, and got a notification that pushing to the wiki failed (although not, interestingly, that pushing to gh-pages failed; maybe it actually pushed something to my personal gh-pages?). I don't want everyone with a fork to get notifications like that every time they push. |
Got it. I took a look and figured out what was going on: the code I used assumed that wiki pages already existed, but there are no wiki pages on your personal fork. The code was written by other people, and perhaps the easiest fix is to turn it off. For gh-pages, yes, those files are in https://github.com/mikeshulman/book/tree/gh-pages |
Thanks. I don't think everyone with a fork should get versions of the book stored on their gh-pages either. |
I was intrigued by #1096, #1098, and #1099 and decided to take a curious look. The current build system is a bit more complicated than I expected. Currently, I am cleaning up the scripts while learning them. This is still a WIP and, while I'm hopeful, I can't guarantee I would achieve something better in the end.
make dvi
make default
in the presence ofupdate-nightlies
update-nightlies
into (1) wiki updater and (2) PDF updater