Memorize which File contains which Pruefi Tables #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collect_pruefis.py collect name of file where pruefi is found in. get_all_pruefis then only looks through that file, which speeds up the search for all pruefis.
hf-kklein
reviewed
Dec 28, 2023
hf-kklein
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Passt für mich. bitte
- verwende
Optional[str]oderstr|NoneanstattUnion[str, None] - überlege, ob an der einen Stelle nicht auch noch der Type Path besser wäre als str
- kommentier an einer stelle noch was keys/values sind
- lass kevin noch drüber schauen
- überprüfe ob die README.md noch aktuell ist was die benutzung angeht
Changed tests to detect those bugs in the future
hf-krechan
reviewed
Jan 15, 2024
hf-krechan
approved these changes
Jan 19, 2024
| @@ -259,11 +266,11 @@ def process_pruefi( | |||
| for ahb_file_path in ahb_file_paths: | |||
| doc = get_or_cache_document(ahb_file_path, path_to_document_mapping) | |||
There was a problem hiding this comment.
ist in dem Repo out of scope, aber die Funktion tut zwei Dinge was sie auch im Namen schon verrät.
Wäre cooler wenn das entsprechend zwei Funktionen sind. Aber das ist für einen anderen PR ^^
| edi_energy_mirror_repo_root_path / Path("edi_energy_de/current"), | ||
| edi_energy_mirror_repo_root_path / Path("edi_energy_de/future"), | ||
| edi_energy_mirror_repo_root_path | ||
| / Path("edi_energy_de/current"), # If you are interested in coming changes, replace "current" with "future" |
There was a problem hiding this comment.
das will ich in Zukunft mit einer flag regeln
This was referenced Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up the process of looking for pruefis, the routine to collect all pruefis is altered to also save the name of the file it found the pruefi in. This information is then used to only look through only one file per pruefi, speeding up the process of getting all existing pruefis.
Successfully merging this pull request may close these issues. #148