📝 Add explanation how to use kohlrahbi #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Was mir noch fehlt ist eine Erklärung, wie das an den edi_energy_mirror ankoppelt. Der taucht an einer Stelle im CLI-Kommando einfach so auf, wird aber nicht in den Kontext gebracht. Letztlich ist kohlrahbi aber hart daran gekoppelt, weil die Benennung der Dateien und die Auswahl welche Dateien zur Extraktion verwendet werden direkt an die Benamsung der docx-files aus dem mirror anknüpft.
Ich würde mir wünschen, dass
- erstmal gesagt wird, dass wir eine Quelle für docx-files brauchen
- dass diese quelle dem namensschema genügen muss (und seie es zur Not mit Link auf die Stellle im Kohlrahbi-coding)
das und vieles mehr: #92
Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de>
hf-kklein
reviewed
Feb 21, 2023
hf-kklein
reviewed
Feb 21, 2023
hf-kklein
approved these changes
Feb 21, 2023
Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.