Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docstrings and comments to better explain repair process and domain generation. #15

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

richardwu
Copy link
Collaborator

No description provided.

for attr in self.all_attrs:
if attr != rv_attr and (not pd.isnull(tuple[attr])):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly a style change where I changed this if statement to a guard block below.

Copy link
Contributor

@minafarid minafarid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minafarid
Copy link
Contributor

I modified the base to dev branch to try it first.

@minafarid minafarid merged commit 91cfa2b into HoloClean:dev Nov 15, 2018
@richardwu richardwu deleted the richard-commenting branch April 7, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants