Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning on ARM #10132

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Remove warning on ARM #10132

merged 1 commit into from
Dec 24, 2020

Conversation

fxcoudert
Copy link
Member

Readying for ARM deployment

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-25 at 13:03:30 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@fxcoudert fxcoudert mentioned this pull request Dec 24, 2020
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you remove

brew/Library/Homebrew/install.rb

Line 56 in a2ae6f8

# Handled by check_for_unsupported_arch in extend/os/mac/diagnostic.rb
before merge? Thanks!

@fxcoudert
Copy link
Member Author

In install.rb I don't understand the purpose of that code. Why are we checking specifically for intel and arm, if later we return unless Hardware::CPU.ppc? anyway? I think it's dead code, so I simplified it.

@MikeMcQuaid
Copy link
Member

In install.rb I don't understand the purpose of that code. Why are we checking specifically for intel and arm, if later we return unless Hardware::CPU.ppc? anyway? I think it's dead code, so I simplified it.

Looks good 👍🏻

@fxcoudert fxcoudert added critical Critical change which should be shipped as soon as possible. and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 24, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 24, 2020 •
edited
Loading

Review period ended.

@fxcoudert fxcoudert merged commit 5818b28 into Homebrew:master Dec 24, 2020
@fxcoudert fxcoudert deleted the arm-warning branch December 24, 2020 14:34
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxcoudert @BrewTestBot @MikeMcQuaid