rubocop: Deal with RSpec cop TODOs
#14884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This matches the code we already have, rather than autocorrecting everything to `have_received`.
- These had a lot of offenses that were marked as "try to enable". - A lot of the "describe class" ones were for tests for cmds or dev-cmds, `brew typecheck` or `brew --env`, and the cop would only pass if I changed these "describe"s to `BrewTypecheck` or `Brew__Env` which seemed unhelpful. - The usefulness of the stubbed mocks cop is [disputed](https://github.com/rubocop/rubocop-rspec/issues/ 1271), and fixing the offenses (not autocorrectable) would involve us doing a fair number of changes since changing `expect` to `allow` would then force us to make each of the affected tests have `expect` assertions at the end, where they sometimes don't currently.
|
Review period will end on 2023-03-07 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
apainintheneck
approved these changes
Mar 4, 2023
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Mar 6, 2023
MikeMcQuaid
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?RSpec/MessageSpieswith the "receive" style.have_received.RSpec/{DescribeClass,StubbedMock}brew typecheckorbrew --env, and the cop would only pass if I changed these "describe"s toBrewTypecheckorBrew__Envwhich seemed unhelpful.expecttoallowwould then force us to make each of the affected tests haveexpectassertions at the end, where they sometimes don't currently.