Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/gems: use HOMEBREW_CACHE for bundler cache. #17304

Merged
merged 1 commit into from
May 15, 2024
Merged

utils/gems: use HOMEBREW_CACHE for bundler cache. #17304

merged 1 commit into from
May 15, 2024

Conversation

MikeMcQuaid
Copy link
Member

Fixes #17276

@MikeMcQuaid MikeMcQuaid requested a review from Bo98 May 15, 2024 12:34
@Bo98
Copy link
Member

Bo98 commented May 15, 2024

Can we reset this at the end so it doesn't bleed into formula test blocks?

@MikeMcQuaid
Copy link
Member Author

Can we reset this at the end so it doesn't bleed into formula test blocks?

@Bo98 Good idea, done.

@Bo98
Copy link
Member

Bo98 commented May 15, 2024

Needs a git push

@MikeMcQuaid
Copy link
Member Author

@Bo98 done and pushed 😅

@carlocab
Copy link
Member

Bad airport wifi again?

@MikeMcQuaid
Copy link
Member Author

Bad airport wifi again?

Sleepy Mike again.

@carlocab carlocab merged commit 56db99e into master May 15, 2024
25 checks passed
@carlocab carlocab deleted the bundler_cache branch May 15, 2024 14:41
@dkav dkav mentioned this pull request May 15, 2024
Closed
1 task
@MikeMcQuaid
Copy link
Member Author

Thanks @Bo98 and @carlocab!

MikeMcQuaid added a commit that referenced this pull request May 17, 2024
@MikeMcQuaid
utils/gems: use BUNDLE_USER_CACHE instead of BUNDLE_CACHE_PATH.
1eb99cd 
Take two at #17304 with the correct
variable name this time.

Fixes #17276.
@MikeMcQuaid MikeMcQuaid mentioned this pull request May 17, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support user set BUNDLE_USER_CACHE
3 participants
@MikeMcQuaid @Bo98 @carlocab