Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: add exemption for nghttp2 #17384

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 28, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Needed for Homebrew/homebrew-core#171634 due to nghttp2/nghttp2#2194.

I've avoided adding an allowlist for now because I really don't want to
see this list grow.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@MikeMcQuaid MikeMcQuaid merged commit d1daf1f into master May 29, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the gcc-dep-nghttp2 branch May 29, 2024 11:50
@MikeMcQuaid
Copy link
Member

Thanks again @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants