cmd/vendor-install: handle broken shasum.
#17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `shasum` is broken and doesn't produce a valid checksum: we were just doing the checksum comparison with an empty checksum. Instead, let's treat an empty checksum as a failure condition, rather than just the executable bit being present for the relevant binary, and iterate through the available tools to try and get a non-empty checksum. If they all produce an empty checksum: provide a different error to make it a bit more obvious what's happening here.
MikeMcQuaid
force-pushed
the
handle_broken_shasum
branch
from
85b9235
to
2c1bf79
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
shasumis broken and doesn't produce a valid checksum: we were just doing the checksum comparison with an empty checksum.Instead, let's treat an empty checksum as a failure condition, rather than just the executable bit being present for the relevant binary, and iterate through the available tools to try and get a non-empty checksum.
If they all produce an empty checksum: provide a different error to make it a bit more obvious what's happening here.