Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing_formula require to Homebrew::CLI::NamedArgs #17809

Conversation

ah91086
Copy link
Contributor

@ah91086 ah91086 commented Jul 19, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

5 days ago we merged a PR that reworked requires, but that has led to some unhandled errors, namely: Error: uninitialized constant Homebrew::CLI::NamedArgs::MissingFormula within Homebrew::CLI::NamedArgs as raised by #17807.

This re_adds the require to address the uninitialized constant.

@apainintheneck apainintheneck added the bug Reproducible Homebrew/brew bug label Jul 19, 2024
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good here and works for me locally.

@apainintheneck
Copy link
Contributor

I suspect that this might rollback a lot of the performance gains from the original PR. It's more important to fix a bug than worry about that now though.

CC: @MikeMcQuaid in case you know of a better way of handling this.

@apainintheneck apainintheneck merged commit e912dc8 into Homebrew:master Jul 19, 2024
24 checks passed
@MikeMcQuaid
Copy link
Member

CC: @MikeMcQuaid in case you know of a better way of handling this.

Yup, opened #17855 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reproducible Homebrew/brew bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants