Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: reject more SPDX licenses #18035

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 13, 2024

Also require licenses on non-disabled formulae

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I am working on adding licenses to all non-disabled formulae, so opening PR to make some license checks stricter.

The extra licenses are only some examples for now (too much effort to make exhaustive), e.g.

Could consider out-sourcing lists but not sure if there is one that fully matches our preferences.

Fedora has their own list but no idea on what their legal requirements are - https://docs.fedoraproject.org/en-US/legal/not-allowed-licenses/

@cho-m cho-m added the in progress Maintainers are working on this label Aug 13, 2024
@Bo98
Copy link
Member

Bo98 commented Aug 13, 2024

May also be worth doing a pass over license :cannot_represent formulae. A lot are missing comments and I reckon some may just be a sneaky bypass for non-open-source software.

@MikeMcQuaid
Copy link
Member

May also be worth doing a pass over license :cannot_represent formulae. A lot are missing comments and I reckon some may just be a sneaky bypass for non-open-source software.

I agree. Honestly, I think license :cannot_represent should be probably removed from Homebrew/homebrew-core.

We should have an attitude of "only include open source software and, if in doubt, exclude" rather than "if in doubt, include".

Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
@cho-m
Copy link
Member Author

cho-m commented Aug 13, 2024

May also be worth doing a pass over license :cannot_represent formulae.

On my todo list. Already have some (like iozone and wpscan) that need to be checked. Others may now be able to use new SPDX identifiers.


I agree. Honestly, I think license :cannot_represent should be probably removed from Homebrew/homebrew-core.

That is the ideal, but SPDX is not ready for that given some important software like DocBook is still pending license identifiers.

Fedora seems to be doing a large scale legal cleanup and have contributed a number of SPDX updates, which has helped reduce some of our :cannot_represent.


On Homebrew side, the next step would be to take any :cannot_represent and link them to corresponding issues/PRs in SPDX repo so we can update them.

@MikeMcQuaid
Copy link
Member

Sounds great, thanks @cho-m!

Also require licenses on non-disabled formulae
@cho-m cho-m marked this pull request as ready for review September 2, 2024 14:53
@cho-m
Copy link
Member Author

cho-m commented Sep 2, 2024

Should be ready for review now.

I've added a short list of examples. May extract this to JSON in future for easier updates. Sadly Debian has no master list. Fedora has one which can be fetched by us, but they have slightly different opinions compared to DFSG (e.g. Artistic-1.0, CC-BY-1.0).

@MikeMcQuaid MikeMcQuaid merged commit 46ef75b into Homebrew:master Sep 2, 2024
27 checks passed
@cho-m cho-m deleted the license-audit branch September 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Maintainers are working on this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants