Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devcontainer: Fix Codespace repository permissions #18211

Merged
merged 1 commit into from
Aug 30, 2024
Merged

devcontainer: Fix Codespace repository permissions #18211

merged 1 commit into from
Aug 30, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As pointed out in 8b3be30#r146048190 (thank you, @noahsettersten!), this was nested wrong. I think this fixes it? JSON is hard!

@issyl0
devcontainer: Fix Codespace repository permissions
1d22b83 
As pointed out in 8b3be30#r146048190 (thank you, @noahsettersten!), this was nested wrong. JSON is hard!
issyl0 referenced this pull request Aug 30, 2024
@issyl0
Tap bundle and services in Codespaces
8b3be30 
- Yes, I wanted to do more Homebrew stuff from Codespaces on my iPad
  because I couldn't be bothered to get out of bed and walk downstairs
  to get my laptop.
- For that I needed my `Homebrew/brew` branch and `brew services`
  tapped, with sufficient permissions for write access so I could
  push commits.
- So I thought I'd do `bundle` as well as it seemed like another
  "would maybe use Codespaces for this" tap.
@issyl0 issyl0 enabled auto-merge August 30, 2024 20:12
@issyl0 issyl0 merged commit b168d91 into master Aug 30, 2024
27 checks passed
@issyl0 issyl0 deleted the devcontainer-fix-codespaces-permissions branch August 30, 2024 20:13
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @MikeMcQuaid @p-linnane