Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scm/git: prevent exec bomb with 'env :userpaths' #46

Closed
wants to merge 1 commit into from
Closed

scm/git: prevent exec bomb with 'env :userpaths' #46

wants to merge 1 commit into from

Commits on Apr 7, 2016

  1. scm/git: prevent exec bomb with 'env :userpaths' 

    Using `git` from `Formula#install` can cause an exec bomb if used in a
formula with `env :userpaths` because that causes both `Library/ENV/4.3`
and `Library/ENV/scm` to be in PATH, both of which contain a `git`
binary that is the same SCM wrapper. Those will mutually exec each other
indefinitely as they fail to detect that they are the same wrapper.

Extend the exec-bomb protection to check the paths after all symbolic
links have been expanded to prevent this situation.

Fixes Homebrew#43.
Fixes Homebrew/homebrew-core#133.
    @UniqMartin
    UniqMartin committed Apr 7, 2016
    Configuration menu
    Copy the full SHA
    e6919e6 View commit details
    Browse the repository at this point in the history