components_order_cop: add all components #4863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?Follow up to #4113
I said in #4113 (comment):
They actually aren't, adding them individually means that some formulae end up needing multiple changes.
Currently ≈
110130 formulae need changes to pass audit with the components in this order.This seems to the the "standard" order for these components but I can change it if this isn't the preferred order.
I've probably missed one or two of the less common components as well, shout at me and I'll add them.
I think we should do this now so it's easier expand this cop to include
stable
/devel
/head
blocks later. The same applies if we're going to add more components (IIRC movinglivecheck
to formulae was mentioned.)I'll submit the necessary changes to core if people are 👍.
https://github.com/Homebrew/homebrew-core/blob/master/Formula/php.rb#L297-L299
Just as a note, this cop doesn't handle stuff like this, so we probably need an generic
method_definition
sort as well, but that's another PR.