[JavaRequirement#satisfies_version] java_version_s: Fix Regular Expression
#5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpression.
The match obtained by applying the regular expression used to index into
the `stderr` member of the result of calling `system_command` in the relevant
variable assignment could yield unexpected results. The regular expression in-
volved was not strict enough and contained an unescaped period, which could
match any character, not just the expected literal decimal point. This commit
corrects this oversight by escaping the relevant character, thus addressing
@apjanke's remark in Homebrew#5280 (comment) on the existence of a:
> …possible bug - that `.` looks like it should be escaped as `\.` to match a
> literal ".".) …
|
Thanks again @RandomDSdevel, nice work! |
RandomDSdevel
deleted the
fix-possible-JavaRequirement-version-parsing-bug
branch
|
You're welcome, @MikeMcQuaid! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally? (All tests pass locally except 'test/os/mac_spec.rb,' which fails with an unrelated error stating that, "Locale::parse' failed to parse 'OS::Mac::language.")Address the second-to-last part of #5280 (comment) per this PR's only commit's message.