Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: return if no github license were found #8402

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Aug 19, 2020

Fixes audit problems when GitHub API returns nil license, like this:
Homebrew/homebrew-core#59865 (comment)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dtrodrigues
Copy link
Member

The intention in #8366 was to only audit if a GitHub license was present, not sure how I missed this.

Co-authored-by: Rylan Polster <rslpolster@gmail.com>
@dawidd6 dawidd6 merged commit af1e600 into Homebrew:master Aug 19, 2020
@dawidd6 dawidd6 deleted the no-gh-license branch August 19, 2020 22:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants