Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software_spec: add on_macos/on_linux to PourBottleCheck #9421

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Dec 4, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Note: This PR is out-of-date, see #9439

Related to Homebrew/homebrew-core#66168

This PR allows pour_bottle? changes in linuxbrew-core to be migrated to homebrew-core

Before:

pour_bottle? do
  reason <<~EOS
    The bottle needs the Apple Command Line Tools to be installed.
      You can install them, if desired, with:
        xcode-select --install
  EOS
  satisfy { !OS.mac? || MacOS::CLT.installed? }
end

After:

pour_bottle? do
  on_macos do
    reason <<~EOS
      The bottle needs the Apple Command Line Tools to be installed.
        You can install them, if desired, with:
          xcode-select --install
    EOS
    satisfy { MacOS::CLT.installed? }
  end
end

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-07 at 19:17:47 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 4, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@SeekingMeaning SeekingMeaning merged commit 1d791a7 into Homebrew:master Dec 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 8, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants