Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

font-noto-serif-cjk 2.002 #8720

Merged
merged 2 commits into from
Nov 29, 2023
Merged

font-noto-serif-cjk 2.002 #8720

merged 2 commits into from
Nov 29, 2023

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Nov 28, 2023

Why need an update

The old url https://noto-website-2.storage.googleapis.com/pkgs/NotoSerifCJK.ttc.zip provides an outdated version 1.001, packed back in 2017. While the latest version is 2.002, see https://github.com/notofonts/noto-cjk/releases/tag/Serif2.002.

Why updated in this way

https://fonts.google.com only provides variable ttf font file in Noto Serif CJK bundle for each language, for example NotoSerifSC[wght].ttf and its corresponding cask font-noto-serif-sc.rb for Noto Serif CJK SC (Simplified Chinese). But this cask provides a static super ttc font file, which is only available from releases of repository https://github.com/notofonts/noto-cjk.

Remark

More casks need to be updated in this way, including symmetric Noto Sans CJK cask font-noto-sans-cjk.rb and language specific Serif and Sans casks like font-noto-sans-cjk-sc.rb.

I started with only one cask to check I did everything right.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added the missing description Cask is missing a description, please add one. label Nov 28, 2023
@bevanjkay
Copy link
Member

bevanjkay commented Nov 28, 2023

Is there a reason for requiring the static fonts over the variable font as distributed by Google Fonts?
Also, is there a reason for continuing with the ttc file over our preferred otf?

EDIT: I think I understand here, it's one file that provides all of the fonts?

@BrewTestBot BrewTestBot removed the missing description Cask is missing a description, please add one. label Nov 28, 2023
@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Nov 28, 2023

Is there a reason for requiring the static fonts over the variable font as distributed by Google Fonts?

Not all softwares can deal with variable fonts, so static ones are still in demand.

Also, is there a reason for continuing with the ttc file over our preferred otf?

I just followed what was provided by this cask, which was a single NotoSerifCJK.ttc. So no strong reason.

@muzimuzhi
Copy link
Contributor Author

From notofonts/noto-cjk repository,

Super OTC

[...] This format is the easiest to install of all the formats and takes the least space for static fonts due to sharing between the 35 parts.

Select this deployment format if you want all five languages and all seven weights in a single and easy-to-manage font resource that includes 35 fonts. [...]

Static OTCs

Select this deployment format if you want all five languages and particular weights, or if your environment does not support the Super OTC. [...]

And from Adobe's famous download guide for corresponding font Source Han Sans/Serif, Super OTC seems recommended for macOS users.
image

@bevanjkay bevanjkay merged commit e325bfb into Homebrew:master Nov 29, 2023
7 checks passed
@muzimuzhi
Copy link
Contributor Author

@bevanjkay Can I ask what's the difference between :stable and :url? I didn't find their definition in https://docs.brew.sh/Brew-Livecheck, or maybe just because I don't speak Ruby.

@muzimuzhi muzimuzhi deleted the bump-font-noto-serif-cjk-2.002 branch November 29, 2023 00:33
@bevanjkay
Copy link
Member

@muzimuzhi It's primarily just a syntactical difference between formula and casks.

@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Nov 29, 2023

Thanks. Another question, to bump casks for font-noto-serif-cjk-<lang>.rb and their sans siblings, I'd like to know is it allowed to update several casks in a single PR?

@bevanjkay
Copy link
Member

Generally we don't allow it, but as these are all related changes it's ok this time.

@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Nov 29, 2023

I decided to do all the bumps in several PRs:

Supplementary

Noto CJK Releases

@muzimuzhi
Copy link
Contributor Author

Now the whole set of Noto Sans & Serif CJK casks are upgraded to use release assets from https://github.com/notofonts/noto-cjk.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants