Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefly v1.0.0 #104435

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Add Firefly v1.0.0 #104435

merged 1 commit into from
Apr 22, 2021

Conversation

rajivshah3
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@miccal
Copy link
Member

miccal commented Apr 22, 2021

Thank you @rajivshah3.

@miccal miccal merged commit baf235e into Homebrew:master Apr 22, 2021
@rajivshah3 rajivshah3 deleted the new-cask/firefly branch April 22, 2021 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants