Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cask google-chat-electron #112094

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Conversation

cdwertmann
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member

@cdwertmann Thank you for your submission.
Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Oct 5, 2021
@cdwertmann
Copy link
Contributor Author

@bevanjkay zap stanza added. The application repo is a fork because the original repo has been abandoned, can you advise on how to proceed?

@bevanjkay bevanjkay added awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting user reply Issue needs response from a user. labels Oct 5, 2021
@SMillerDev
Copy link
Member

If the original repo is abandoned and upstream is therefore never going to merge back they might be interested in un-forking their repository.

@cdwertmann
Copy link
Contributor Author

@ankurk91 would you be open to that idea?

@ankurk91
Copy link

ankurk91 commented Oct 5, 2021

What is the official way to un-fork?

Would this work?
https://ralphjsmit.com/unfork-github-repo/

@ankurk91
Copy link

ankurk91 commented Oct 5, 2021

The repo has been detached now.

@gdams gdams added the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Oct 5, 2021
@BrewTestBot BrewTestBot removed the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Oct 5, 2021
@miccal
Copy link
Member

miccal commented Oct 6, 2021

Thank you @cdwertmann.

@miccal miccal merged commit 36e9c96 into Homebrew:master Oct 6, 2021
@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 6, 2021
@cdwertmann cdwertmann deleted the google-chat-electron-1 branch October 6, 2021 05:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants