Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell: update caveats #170730

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

ZhongRuoyu
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  1. Clarify that the commands need to be run in a PowerShell session.
  2. Make sure the directory is created before attempting to write to the profile.

Fixes #170589.

1. Clarify that the commands need to be run in a PowerShell session.
2. Make sure the directory is created before attempting to write to the
   profile.

Fixes Homebrew#170589.
@krehel krehel merged commit 790e21a into Homebrew:master Apr 5, 2024
9 checks passed
@krehel
Copy link
Member

krehel commented Apr 5, 2024

Thanks @ZhongRuoyu!

@ZhongRuoyu ZhongRuoyu deleted the powershell-caveats branch April 5, 2024 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

powershell caveats not reproducible
2 participants