Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvdstyler 3.2.1_1 fixed url #174574

Merged
merged 2 commits into from
May 23, 2024
Merged

dvdstyler 3.2.1_1 fixed url #174574

merged 2 commits into from
May 23, 2024

Conversation

rlpvin
Copy link
Contributor

@rlpvin rlpvin commented May 22, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

From issue: #172732 (comment)

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label May 22, 2024
Casks/d/dvdstyler.rb Outdated Show resolved Hide resolved
Co-authored-by: Bevan Kay <bevanjkay@gmail.com>
@bevanjkay
Copy link
Member

Thank you @rlpvin

Can you try to add a zap stanza in a follow up PR?
The linked documentation provides some recommended methods to create it.

@bevanjkay bevanjkay enabled auto-merge May 23, 2024 00:04
@bevanjkay bevanjkay merged commit c45e39c into Homebrew:master May 23, 2024
9 checks passed
@rlpvin
Copy link
Contributor Author

rlpvin commented May 23, 2024

Of course! I'll try to add a zap stanza. Thanks for the feedback!

@rlpvin rlpvin deleted the dvdstyler branch May 23, 2024 00:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
missing zap Cask is missing a zap stanza, please add one. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants