Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mac-mouse-fix@2.rb #174815

Merged
merged 1 commit into from
May 26, 2024
Merged

Create mac-mouse-fix@2.rb #174815

merged 1 commit into from
May 26, 2024

Conversation

junian
Copy link
Contributor

@junian junian commented May 25, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member

Can you comment on the reason for wanting to add this as a versioned cask?

@junian
Copy link
Contributor Author

junian commented May 25, 2024

The Mac Mouse Fix v3 is paid product with 30 days trial.

The v2 is free product with less features.

I'm not against the dev decision to make it paid product, in fact I support it. But maybe some users still want to keep using v2 even though it has less features. The dev even gave update to v2 recently by notarizing the binary.

Hope the intention is clear.

Thank you.

image

@krehel
Copy link
Member

krehel commented May 25, 2024

I'll add this from the 3.0.2 release page that will provide documentation for future reference.

Screenshot 2024-05-25 at 7 49 42 AM

@p-linnane p-linnane merged commit 2d33eb2 into Homebrew:master May 26, 2024
9 checks passed
@junian junian deleted the patch-1 branch May 30, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants