Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add zap stanza #88809

Merged
merged 1 commit into from
Sep 7, 2020
Merged

cmake: Add zap stanza #88809

merged 1 commit into from
Sep 7, 2020

Conversation

muneebmahmed
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask audit --new-cask {{cask_file}} worked successfully.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.

I noticed cmake did not have a zap stanza for its preferences files, so I added one. I found these files manually with AppCleaner

@vitorgalvao vitorgalvao merged commit 13b047d into Homebrew:master Sep 7, 2020
@muneebmahmed muneebmahmed deleted the zap-cmake branch September 7, 2020 03:46
@3719e04 3719e04 mentioned this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants